Skip to content

feat: add custom auth demo in playground #5418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2024
Merged

feat: add custom auth demo in playground #5418

merged 1 commit into from
Nov 14, 2024
+153 −7

Conversation

@ElasticBottle
Copy link
Contributor

@ElasticBottle ElasticBottle commented Nov 14, 2024 •
edited by pr-codex bot
Loading

https://linear.app/thirdweb/issue/CNCT-2364/custom-auth-demo-in-playground

PR-Codex overview

This PR introduces a new CustomLoginForm component for user authentication using an email address. It integrates a custom authentication strategy with the inAppWallet, enhancing the user experience by allowing seamless login and error handling.

Detailed summary

  • Added CustomLoginForm component in custom-login-form.tsx.
  • Implemented email input and submission handling with useState and useMutation.
  • Integrated inAppWallet for custom authentication.
  • Updated page.tsx to include CustomLoginForm in the UI with a new section for custom auth and UI.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 8:51pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 14, 2024 8:51pm
thirdweb-www ⬜️ Skipped (Inspect) Nov 14, 2024 8:51pm
wallet-ui ⬜️ Skipped (Inspect) Nov 14, 2024 8:51pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e958e75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 14, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Nov 14, 2024
@codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (b620dee) to head (e958e75).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5418   +/-   ##
=======================================
  Coverage   45.52%   45.52%           
=======================================
  Files        1070     1070           
  Lines       55665    55665           
  Branches     4030     4030           
=======================================
  Hits        25341    25341           
  Misses      29637    29637           
  Partials      687      687
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b620dee
packages 40.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 320 ms (-11.06% 🔽) 1.3 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 901 ms (+7.73% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 182 ms (+477.01% 🔺) 296 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 44 ms (+225.57% 🔺) 54 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 180 ms (+51.45% 🔺) 556 ms

@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 14, 2024 14:26 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 14, 2024 14:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 14, 2024 14:26 Inactive
@joaquim-verges
Copy link
Member

joaquim-verges commented Nov 14, 2024

@ElasticBottle on the dev preview i get a 401 btw

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 14, 2024
@gregfromstl Graphite App
Copy link
Contributor

gregfromstl commented Nov 14, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 14, 3:49 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 14, 3:49 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 14, 3:53 PM EST: A user merged this pull request with the Graphite merge queue.

@ElasticBottle
feat: add custom auth demo in playground (#5418)
e958e75 
https://linear.app/thirdweb/issue/CNCT-2364/custom-auth-demo-in-playground

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new `CustomLoginForm` component for handling user authentication via email in the `in-app-wallet` feature. It allows users to log in with a custom authentication endpoint while integrating with existing wallet functionalities.

### Detailed summary
- Added `CustomLoginForm` component in `custom-login-form.tsx`.
- Utilized `useMutation` for handling login requests with an email.
- Implemented email input and submission handling in the `CustomLoginForm`.
- Updated `page.tsx` to include `CustomLoginForm` with a new section for custom authentication UI.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the winston/add-custom-auth-to-playground branch from 55a926a to e958e75 Compare November 14, 2024 20:50
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 14, 2024 20:50 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 14, 2024 20:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 14, 2024 20:50 Inactive
@graphite-app graphite-app bot merged commit e958e75 into main Nov 14, 2024
31 checks passed
@graphite-app graphite-app bot deleted the winston/add-custom-auth-to-playground branch November 14, 2024 20:53
@vercel vercel bot temporarily deployed to Production – thirdweb-www November 14, 2024 20:53 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 14, 2024 20:53 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 14, 2024 20:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

@jnsdls jnsdls Awaiting requested review from jnsdls

Assignees

No one assigned

Labels

merge-queue Adds the pull request to Graphite's merge queue. Playground Changes involving the Playground codebase.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ElasticBottle @joaquim-verges @gregfromstl